Update to 2.3.0 Ja good template menu is now on 2 lign

folamour

hi my menu was fitting on 1 lign before, but with the update to 2.3.0 the menu is now on 2 lign and i cannot reduce the number of item....

Before

After

saguaros

folamour Hi

I think the Dark/Light mode toggle button occupied the space and push an item down.

A possible approach is you can move that button to the topbar.
1/ Open this file: JROOT/templates/ja_good/tpls/blocks/topbar.php
Add this line of code:
<?php $this->loadBlock('theme-toggle') ?>

2/ Remove the same line of code in this file: JROOT/templates/ja_good/tpls/blocks/header/header_news.php

folamour

hi sagaros that worked for the menu but i decided to completely get ride of the black/white toogle button

so i dont added <?php $this->loadBlock('theme-toggle') ?> to JROOT/templates/ja_good/tpls/blocks/topbar.php

and i removed <?php $this->loadBlock('theme-toggle') ?>

from JROOT/templates/ja_good/tpls/blocks/header/header_news.php

but my CLS went from 0 to 0.54 and my gt metrix score from grade A 98% 94% to grade B 78% 76%

hope you can help me, i just want my menu back and no black / white toggle switch and keep my score intact

folamour

hi sagaros, i'll managed to make my menu fit on one lign, and get the benefit of white/black switch but...
when switching to black

1/ my logo appear as a white rectangle (he's background black, and character in white)

2/ big problem when switching to black, asap i read an article or i navigate to a menu, the white background get back, the template did not remember i'll switched to black

but all speed is now ok, no more cls issue, no more speed issue ; ))))

hope you can help

Thanks a lot,

saguaros

folamour Hi

Are you working on it? as I can see the theme toggle button is still there and the logo in white already.

folamour

hi saguaros i went back to ja good 2.20 because there is a random error on ja Good 2.30 making jump 1 test on 3 GTmetrix @ cls 0.65 score B 77%

from that i have saw, it seem to be the brick module who make the jump in CLS,

we cannot have a score of B because of core web vital,
so i'll checked my website with cassiopea and run 10 test in a row the CLS is 0.

so hopefully i have keep previous release of ja good for joomla 5 the template is 2.20.0

And now its rock solid 10 test in a row CLS 0 or 0.1 !!!

hope you can fix that Ja Good 2.30 seem promising.

saguaros

folamour Hi

It's weird as I tested my dev site with the new version but there is no issue with CLS. I will also forward to dev team for further review.

folamour

thanks a lot saguaros, it pass the test 2 time on 3 with the 3rd test is horrible 🙁(((((((((((((((

i can switch to ja good 2.30 and give your more insigth (the reason of the cls)

thanks !

saguaros

I don't have premium account in gtmetrix, I just run the test with it: