Discussion thread for "important changes in the JA Templates Club"

[bossep]

VisiGod,
I take your word for it! And thanks for your points and clarifications. In adition I agree to 100% with you.
In general I dont like work arounds on open source ware people ary trying to put some dadded value to it and then sell it or integrate it repackaged mybe with a little not about it (check IE help for the little ref to Mosaic! if you can find it)

Off to studdy code

Bosse

[bossep]

Thanks perdu,
I am currently studying the code of this function and trying to find out were it is called and when.
In general, my hair on arm, legs and hair is standing up when something I use calls an external server and submits something from the user table in my DB specially if it is the admin account like this one does.
This is the code for the function checkupdate().

function checkupdate() {
$database = JFactory::getDBO();

$database->setQuery("SELECT MIN(id) from `#__users`");
$idmin = $database->loadResult();

$query = "SELECT params from #__users WHERE id=$idmin";
$database->setQuery($query);
$content =  $database->loadResult();
$params = new JParameter($content);

if($params->get('checkUpdateVersDate')!=date("Ymd")){
$params->set('checkUpdateVersDate', date("Ymd"));
$content = $params->toString();

$query = "UPDATE `#__users` SET `params`='$content'  WHERE `id`=$idmin";
$database->setQuery($query);
$database->query();

$datas = '$J#PRODUCT_KEY$,$J#OWNER$,'.JURI::base();
$req = "datas=$datas";
$url = '/checkversion.php';
$address = "www3.joomlart.com";
$port = 80;
$header = "POST $url HTTP/1.0\r\n";
$header .= "Host: $address\r\n";
$header .= "Content-Type: application/x-www-form-urlencoded\r\n";
$header .= "Content-Length: " . strlen ($req) . "\r\n\r\n";
$fp = fsockopen($address,80);

if (!$fp) return false;
@fputs ($fp, $header . $req);
$res = '';

while (!@feof($fp)){
$res .=@ fgets ($fp, 1024);
}
@fclose ($fp);
preg_match('/\r\n\r\n(.+)$/m', $res, $regs);
//Get result
$lastestVers = $regs[1];
$lastestVers = explode( '-', $lastestVers);

//get content from .xml file
$filename = dirname(__FILE__).DS."templateDetails.xml";

if (file_exists($filename) && is_writable($filename)) {
$data = '';
$fh = fopen($filename, 'rb');
if ($fsize = filesize($filename)) {
$data = fread($fh, $fsize);
}
fclose($fh);

$posfirstVers = strpos($data, '<version>');
$poslastVers  = strpos($data, '</version>');

$firstContent = substr($data, 0, $posfirstVers);
$lastContent  = substr($data, $poslastVers+10);
$versContent  = substr($data, $posfirstVers+9, 
($poslastVers- $posfirstVers-9));

$curVers 	  = explode('-', $versContent);
$curVers	  = count($curVers)?$curVers[0]:'1.0';
$lastVerContent = "<version>$curVers-&lt;a href=\"".$lastestVers[0]."\" target=\"_blank\" &gt;Lastest: ".$lastestVers[1]." &lt;/a&gt;</version>";
$newdatas = $firstContent.$lastVerContent.$lastContent;

if (($fh = @fopen($filename, 'w+', 1)) === false) {
return false;
}
$bytes = 0;
if (($bytes = @fwrite($fh, $newdatas)) === false) {
return false;
}

@fclose($fh);
	}
         }
}
}

Perhaps some one else (JA?) could explain what this is about.

Bosse

[VisiGod]

It is sending the data for the admin account
However, this could be easily lied with the current function.

1. Create a dummy user
2. Create a new super administrator
3. Delete the first super administrator
4. Install the template

and JA will receive the data of the dummy user

[bossep]

FANTASTIC!....
VisiGod,
Perhaps I could create a F-you user? or include a format C: code or...
As I see this it is making a call to this thing when the index.php is opened trough the ja_vars_1.5.php
but I might be wrong.

I just love it. Thinking, who has a template I can use insted of Teline...

Logic, So as I am a Developer member creating websites for others that might not like ME to have admin or super admin rights they will be accused of piracy?

I normally try to figure out the good intentions of somthing like this. for instance a routine that checks my version and compare it with the last version and offer me to install the latest version. Pretty good client service! But then the logic should be to have it in the admin section od the site. Not the front end!


Bosse

[VisiGod]

To be honest I don't see this function called somewhere, which is strange.

[cgc0202]

I could state clearly, that there were no call home functions till the moment.

Thanks VisiGod,

For the average user, are there ways to find out any added codes to a huge code files and directories, such as the Joomla-Joomlart template?

Cornelio

[VisiGod]

Cornelio, we can see that in the last template there is a callback as one found above.
However, I couldn't find if it is run some way.

[bossep]

Cornelio,
I use Dreamweaver and the find all thing.

[VisiGod]

Well, I use Eclipse, either nothing.
But still ... the function is there :(

What I am more afraid of is that this file ja_templatetools_1.5.php IS NOT SECURED.

It lacks the defined( '_JEXEC' ) or die( 'Restricted access' );
Which means, it is very possible to be run remotely.

[cgc0202]

Look in template tools in the nagya template

$datas = '$J#PRODUCT_KEY$,$J#OWNER$,'.JURI::base();
$req = "datas=$datas";
$url = '/checkversion.php';
$address = "www3.joomlart.com";
$port = 80;
$header = "POST $url HTTP/1.0\r\n";
$header .= "Host: $address\r\n";
$header .= "Content-Type: application/x-www-form-urlencoded\r\n";
$header .= "Content-Length: " . strlen ($req) . "\r\n\r\n";
$fp = fsockopen($address,80);

Hi perdu,

Which specific file is this?

And, exactly what is the significance?

Cornelio